This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
Dump docker logs #4868
Merged
Dump docker logs #4868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wiezzel
force-pushed
the
dump_docker_logs
branch
2 times, most recently
from
6ff43ee
to
7fea99b
Compare
Codecov Report
@@ Coverage Diff @@
## b0.22 #4868 +/- ##
==========================================
+ Coverage 89.18% 89.23% +0.05%
==========================================
Files 231 233 +2
Lines 21287 21382 +95
==========================================
+ Hits 18984 19080 +96
+ Misses 2303 2302 -1 |
Wiezzel
force-pushed
the
dump_docker_logs
branch
from
7fea99b
to
2840b21
Compare
maaktweluit
approved these changes
Nov 8, 2019
Wiezzel
force-pushed
the
dump_docker_logs
branch
3 times, most recently
from
f91106b
to
f5e12b0
Compare
Signed-off-by: Adam Wierzbicki <awierzbicki@golem.network>
Signed-off-by: Adam Wierzbicki <awierzbicki@golem.network>
Wiezzel
force-pushed
the
dump_docker_logs
branch
from
f5e12b0
to
f57f12c
Compare
mfranciszkiewicz
approved these changes
Nov 12, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docker container output (and runtime output in general) is needed for debugging purposes. Implemented an environment wrapper that will automatically dump these outputs to text files and print the filenames in Golem logs.
Slight changes in the
EnvironmentandRuntimeinterfaces were needed to make the solution generic. Also done some refactoring in theauto_setupwrapper to avoid code repetition.