This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
Fixed DummyHypervisor port mapping for Windows #4876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Windows docker-machine command has to be used to get the VM's IP address. This code is just temporary workaround until non-hypervised envs are removed.
Wiezzel
force-pushed
the
windows_docker_ports
branch
from
ef8073e to
61e5c41
Compare
mfranciszkiewicz
approved these changes
Nov 13, 2019
Codecov Report
@@ Coverage Diff @@
## b0.22 #4876 +/- ##
==========================================
+ Coverage 89.19% 90.17% +0.97%
==========================================
Files 233 233
Lines 21383 21390 +7
==========================================
+ Hits 19073 19288 +215
+ Misses 2310 2102 -208 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows docker-machine command has to be used to get the VM's IP address. This code is just temporary workaround until non-hypervised envs are removed.