This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
Fixed CPU time limit calculation #4909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbenke
reviewed
Nov 19, 2019
There was a problem hiding this comment.
Something seems wrong here - the cpu limit seems to be always 3600, no matter what the task budget:
INFO [golem.task.taskcomputer ] Starting computation of subtask 'cd5dbb18-0a9c-11ea-8580-054089b37bde' (task: 'c18d9810-0a9c-11ea-bcfe-054089b37bde', deadline: 1574147954, docker images: [{'repository': 'golemfactory/wasm', 'image_id': None, 'tag': '0.5.4'}], cpu_limit: 3600)
This probably stems from https://github.com/golemfactory/golem/blob/develop/golem/task/tasksession.py#L453
mbenke
suggested changes
Nov 19, 2019
Co-Authored-By: Marcin Benke <marcin.benke@golem.network>
mbenke
reviewed
Nov 19, 2019
kmazurek
force-pushed
the
fix/cpu-limit
branch
from
e49150a
to
7b83f52
Compare
mbenke
approved these changes
Nov 20, 2019
Codecov Report
@@ Coverage Diff @@
## b0.22 #4909 +/- ##
==========================================
+ Coverage 89.23% 90.18% +0.95%
==========================================
Files 233 233
Lines 21454 21458 +4
==========================================
+ Hits 19144 19352 +208
+ Misses 2310 2106 -204 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.