This repository was archived by the owner on Oct 31, 2023. It is now read-only.
properly handle initialization failures #4951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etam
force-pushed
the
fix_incorrect_task_state_in_init_failure
branch
from
e2869c6 to
e73aa9f
Compare
Wiezzel
reviewed
Dec 2, 2019
etam
commented
Dec 5, 2019
| task.header.concent_enabled, | ||
| force | ||
| ) | ||
| except Exception as exc: # pylint: disable=broad-except |
There was a problem hiding this comment.
I deleted this, because at this point the task is not registered in TaskManager yet.
Wiezzel
approved these changes
Dec 5, 2019
etam
force-pushed
the
fix_incorrect_task_state_in_init_failure
branch
from
138afee to
4369933
Compare
mfranciszkiewicz
approved these changes
Dec 5, 2019
Codecov Report
@@ Coverage Diff @@
## b0.22 #4951 +/- ##
=========================================
+ Coverage 90.1% 90.13% +0.02%
=========================================
Files 233 233
Lines 21788 21784 -4
=========================================
+ Hits 19633 19634 +1
+ Misses 2155 2150 -5 |
etam
force-pushed
the
fix_incorrect_task_state_in_init_failure
branch
from
4369933 to
dda129d
Compare
|
I squashed commits and rebased onto latest b0.22 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4850