This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
Send evt.net.connection only when status changes #4958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## b0.22 #4958 +/- ##
=========================================
+ Coverage 89.2% 90.15% +0.94%
=========================================
Files 233 233
Lines 21773 21780 +7
=========================================
+ Hits 19423 19636 +213
+ Misses 2350 2144 -206 |
jiivan
force-pushed
the
b0.22-hold_your_net_status
branch
from
5e2e47a
to
32223a0
Compare
etam
suggested changes
Dec 2, 2019
| def test_run(self, logger): | ||
| @patch('golem.client.NetworkConnectionPublisherService.poll') | ||
| def test_run(self, poll_mock, logger): | ||
| poll_mock.return_value = {'random_key': random.random()} |
There was a problem hiding this comment.
This might very rarely fail, because it might produce the same value twice. You can assign an array to side_effect and it will return next value for each call.
There was a problem hiding this comment.
It won't fail, because service is initialized in .setUp() which uses original .poll() implementation, that returns totally different kind of dict. Also this value is returned only once.
etam
approved these changes
Dec 3, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #4957