This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
Log during startup about environment register status #4968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etam
reviewed
Dec 18, 2019
golem/envs/default.py
Outdated
| if NonHypervisedDockerGPUEnvironment.supported().supported: | ||
| _register_docker_gpu_env(work_dir, env_manager) | ||
| for (env_id, env_cls, _register) in ENVS: | ||
| if env_id in TASK_API_ENVS: |
There was a problem hiding this comment.
how about this?
if env_id not in TASK_API_ENVS:
logger.debug('Environment disabled. env_id=%r', env_id)
continue
if not env_cls.supported().supported:
logger.info('Environment not supported. env_id=%r', env_id)
continue
logger.info('Registering environment. env_id=%r', env_id)
_register(work_dir, env_manager)makes it a bit more flat and puts error handling near condition checking.
There was a problem hiding this comment.
nice one! fixed it :)
Codecov Report
@@ Coverage Diff @@
## develop #4968 +/- ##
===========================================
- Coverage 89.91% 89.91% -0.01%
===========================================
Files 238 238
Lines 22407 22413 +6
===========================================
+ Hits 20147 20152 +5
- Misses 2260 2261 +1 |
|
|
maaktweluit
force-pushed
the
mwu/task-api-env-status-log
branch
from
0e87484
to
bdd3048
Compare
Wiezzel
approved these changes
Mar 20, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also moved it to a loop since the code was getting repetative