This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
update requirements #4990
Merged
update requirements #4990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maaktweluit
suggested changes
Dec 12, 2019
There was a problem hiding this comment.
python-dateutil==2.8.1
is now duplicate and should be removed from requirements-lint.txt
https://buildbot.golem.network/buildbot/#/builders/8/builds/16523
maaktweluit
approved these changes
Dec 12, 2019
|
|
etam
force-pushed
the
update_requirements
branch
from
aaf0624
to
cd76b25
Compare
Codecov Report
@@ Coverage Diff @@
## b0.22 #4990 +/- ##
==========================================
- Coverage 90.11% 90.11% -0.01%
==========================================
Files 233 233
Lines 21870 21870
==========================================
- Hits 19709 19708 -1
- Misses 2161 2162 +1 |
|
by the way: multidict issue with pyinstaller should be fixed by now: pyinstaller/pyinstaller#4572 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just used
pip freezeon a fresh venv and manually adjusted multidict version. It has no further dependencies, so it should be fine.