This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
Ignore application errors in ProviderProxy #4997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## b0.22 #4997 +/- ##
==========================================
+ Coverage 90.05% 90.11% +0.05%
==========================================
Files 233 233
Lines 21902 21902
==========================================
+ Hits 19723 19736 +13
+ Misses 2179 2166 -13 |
jiivan
force-pushed
the
b0.22-known-geth-qfix
branch
from
8b6c745
to
fda059d
Compare
jiivan
force-pushed
the
b0.22-known-geth-qfix
branch
2 times, most recently
from
9e766d1
to
2804e29
Compare
jiivan
force-pushed
the
b0.22-known-geth-qfix
branch
from
2804e29
to
12fa48f
Compare
jiivan
changed the title
maaktweluit
approved these changes
Dec 18, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All
ValueErrors generated inweb3seem to be application logic errors, not connection issues. Therefore it seems wise to just reraise them inProviderProxy.Typical
ValueErrors are:Some of them are already handled by ŚCI.