Skip to content
This repository has been archived by the owner on Oct 31, 2023. It is now read-only.

early exit from blockchain monitor on shutdown #5006

Merged
merged 3 commits into from
Dec 18, 2019

Conversation

shadeofblue
Copy link
Contributor

No description provided.

Copy link
Contributor

@maaktweluit maaktweluit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT!

Small nitty comment

@@ -91,7 +91,7 @@ def _create_remote_rpc_provider(self):
def _handle_remote_rpc_provider_failure(self, method: str, final: bool):
if final:
raise Exception(
"GETH: Node limit exhausted, request failed. method='%s'",
"GETH: Node limit exhausted, request failed. method='%s'" %
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would use f"{method}"

@shadeofblue shadeofblue force-pushed the 0.22-sci-1.10.4-early-exit-from-blockchain-monitor branch from 15dd40e to 373f9bf Compare December 18, 2019 15:01
@codecov
Copy link

codecov bot commented Dec 18, 2019

Codecov Report

Merging #5006 into b0.22 will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           b0.22    #5006      +/-   ##
=========================================
- Coverage   90.1%   90.09%   -0.01%     
=========================================
  Files        233      233              
  Lines      21902    21902              
=========================================
- Hits       19735    19733       -2     
- Misses      2167     2169       +2

@shadeofblue shadeofblue merged commit 022be63 into b0.22 Dec 18, 2019
@shadeofblue shadeofblue deleted the 0.22-sci-1.10.4-early-exit-from-blockchain-monitor branch December 18, 2019 16:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants