This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
Added legacy fields to task-api comp.task rpc command #5018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think you should change the base branch here to |
|
@zakaprov you are correct, thanks! Updated the base |
maaktweluit
force-pushed
the
mwu/b0.22/comp.task-fill-all-fields
branch
from
a8a1d47
to
d46e061
Compare
mfranciszkiewicz
approved these changes
Jan 7, 2020
Codecov Report
@@ Coverage Diff @@
## b0.22 #5018 +/- ##
==========================================
- Coverage 90.08% 89.97% -0.11%
==========================================
Files 234 234
Lines 21965 21998 +33
==========================================
+ Hits 19787 19793 +6
- Misses 2178 2205 +27 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way electron does not crash after adding a task-api task.