Skip to content
This repository has been archived by the owner on Oct 31, 2023. It is now read-only.

address a security vulnerability in pyinstaller < 3.6 #5052

Merged
merged 7 commits into from
Jan 22, 2020

Conversation

shadeofblue
Copy link
Contributor

No description provided.

Copy link
Contributor

@jiivan jiivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tworecapproves

@codecov
Copy link

codecov bot commented Jan 20, 2020

Codecov Report

Merging #5052 into b0.22 will decrease coverage by 2.29%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            b0.22    #5052     +/-   ##
=========================================
- Coverage   90.04%   87.74%   -2.3%     
=========================================
  Files         234      234             
  Lines       22000    21999      -1     
=========================================
- Hits        19809    19303    -506     
- Misses       2191     2696    +505

Copy link
Contributor

@maaktweluit maaktweluit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would tripple check the produced binaries, they could have issues building or running when hooks changed.

@shadeofblue
Copy link
Contributor Author

Would tripple check the produced binaries, they could have issues building or running when hooks changed.

well, sure, first they need to build at all :)

@maaktweluit maaktweluit force-pushed the 0.22.1-bump-pyinstaller branch from ebdf7be to 130b531 Compare January 21, 2020 13:14
@shadeofblue shadeofblue merged commit ce246a3 into b0.22 Jan 22, 2020
@shadeofblue shadeofblue deleted the 0.22.1-bump-pyinstaller branch January 22, 2020 18:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants