This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
Add deadlines to message queue entries #5106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a deadline field to the the database model QueuedMessage. Extends message queue logic to discard messages which are past their deadline. When putting new messages to the queue an optional timeout parameter can be specified. A message's deadline is derived from this timeout. This change also adds a timeout for ResourceHandshakeStart and WantToComputeTask messages.
jiivan
reviewed
Feb 26, 2020
etam
reviewed
Feb 27, 2020
etam
reviewed
Feb 27, 2020
|
BTW, why is this needed? |
Codecov Report
@@ Coverage Diff @@
## develop #5106 +/- ##
===========================================
+ Coverage 90.01% 90.02% +<.01%
===========================================
Files 234 234
Lines 22082 22091 +9
===========================================
+ Hits 19877 19887 +10
+ Misses 2205 2204 -1 |
jiivan
reviewed
Feb 27, 2020
golem/network/transport/msg_queue.py
Outdated
| - variables.MESSAGE_QUEUE_MAX_AGE | ||
| count = model.QueuedMessage.delete().where( | ||
| count += model.QueuedMessage.delete().where( |
There was a problem hiding this comment.
Please use only deadline here
|
@etam Together with setting the timeout for |
jiivan
approved these changes
Feb 27, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a deadline field to the the database model QueuedMessage. Extends
message queue logic to discard messages which are past their deadline.
When putting new messages to the queue an optional timeout parameter
can be specified. A message's deadline is derived from this timeout.
This change also adds a timeout for ResourceHandshakeStart and
WantToComputeTask messages.
fixes: #5105