This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiivan
force-pushed
the
dev-version-broadcast
branch
7 times, most recently
from
February 28, 2020 15:41
0a80a2d
to
1f91681
Compare
jiivan
force-pushed
the
dev-version-broadcast
branch
from
February 28, 2020 16:11
1f91681
to
13bf155
Compare
maaktweluit
approved these changes
Mar 3, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Small comments, please fix or reply before merge
Approving to get those full tests running
Codecov Report
@@ Coverage Diff @@
## develop #5109 +/- ##
==========================================
Coverage ? 89.89%
==========================================
Files ? 237
Lines ? 22321
Branches ? 0
==========================================
Hits ? 20065
Misses ? 2256
Partials ? 0 |
etam
reviewed
Mar 3, 2020
etam
reviewed
Mar 3, 2020
etam
reviewed
Mar 3, 2020
etam
reviewed
Mar 4, 2020
Co-Authored-By: Adam Mizerski <amizerski@golem.network>
… into dev-version-broadcast
etam
reviewed
Mar 4, 2020
etam
reviewed
Mar 4, 2020
etam
reviewed
Mar 4, 2020
etam
reviewed
Mar 4, 2020
etam
reviewed
Mar 4, 2020
etam
reviewed
Mar 4, 2020
jiivan
force-pushed
the
dev-version-broadcast
branch
from
March 4, 2020 13:19
67d939e
to
2fa58ed
Compare
jiivan
force-pushed
the
dev-version-broadcast
branch
from
March 4, 2020 13:23
2fa58ed
to
20e6176
Compare
jiivan
force-pushed
the
dev-version-broadcast
branch
from
March 4, 2020 13:59
67a3f59
to
3290686
Compare
etam
reviewed
Mar 4, 2020
etam
approved these changes
Mar 5, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jiivan Looking through the logs of the last test run I noticed that
They seem to be unnecessary for end users and will also attribute to log spam as multiple lines will be printed for each connection. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.