This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
Load app definition files from Golem releases CDN #5114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmazurek
force-pushed
the
remote-app-definitions
branch
from
4640c07 to
49db37a
Compare
Codecov Report
@@ Coverage Diff @@
## develop #5114 +/- ##
==========================================
Coverage ? 90.04%
==========================================
Files ? 236
Lines ? 22227
Branches ? 0
==========================================
Hits ? 20015
Misses ? 2212
Partials ? 0 |
shadeofblue
reviewed
Mar 4, 2020
golem/core/variables.py
Outdated
| @@ -75,6 +75,8 @@ | |||
| # How long should peer be banned when failing on resources (seconds) | |||
| ACL_BLOCK_TIMEOUT_RESOURCE = 2 * 3600 # s | |||
|
|
|||
| APP_DEFINITIONS_CDN_URL = 'https://golem-app-definitions.s3.eu-central-1.amazonaws.com/' # noqa pylint: disable=line-too-long | |||
There was a problem hiding this comment.
shouldn't that rather be some subdomain in golem.network that would redirect to s3? ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: https://github.com/golemfactory/golem/issues/5099
Adds logic for downloading app definition JSON files from CDN in Task API
AppManager. The definition files are distinguished based on their file name (which, among other things, should contain the hash of the file's contents). Updating apps is done uponAppManagerinit and then periodically (once a day usingDailyJobsService). For every new definition downloaded an RPC event is fired (evt.apps.new_definition).