-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature add ability to run golem and concent tests #271
base: master
Are you sure you want to change the base?
Feature add ability to run golem and concent tests #271
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some tweaks are needed.
I have a question: what about settings? Does it require any special configuration in local_settings.py
? If not, why? The fact that everyone has different settings was a big problem for us in development.
scripts/concent_acceptance_tests/force_accept \ | ||
--maxfail=1 \ | ||
-vs \ | ||
--lf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use long option names in our examples: --last-failed
, --verbose
, --capture=no
.
|
||
source concent-env.sh | ||
./full-check.sh | ||
./api-e2e-tests.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please allow passing the cluster address to api-e2e-tests.sh
.
@@ -536,6 +536,12 @@ Updates Concent to the version (tag/branch/commit) specified in the first parame | |||
- Installs Concent dependencies in the virtualenv. | |||
- Migrates the databases. | |||
|
|||
###### `concent-run-all-tests.sh` | |||
This script run all concent tests, before execute, you must run the `concent-run.sh` script in a second console. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please reword:
This script runs all of Concent's tests.
The only parameter is the address of a Concent cluster.
If not specified, it will try to connect to Concent running inside the machine.
You need to have a Concent server and its workers running in that case.
You can start it by executing `concent-run.sh` in another terminal session.
@@ -567,6 +573,20 @@ You can see all the available `golemapp` options by running: | |||
golem-run-console-mode.sh --help | |||
``` | |||
|
|||
###### `golem-run-concent-integration-tests.sh` | |||
Starts Golem integration tests for concent. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
concent
-> Concent
.
scripts/concent_acceptance_tests/force_accept \ | ||
--maxfail=1 \ | ||
-vs \ | ||
--lf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this script should have some defaults. By default it should runn all the integration tests with the options you specified above (if those are the options we usually use).
No description provided.