Feature add ability to run golem and concent tests #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cameel
suggested changes
Dec 14, 2018
| scripts/concent_acceptance_tests/force_accept \ | ||
| --maxfail=1 \ | ||
| -vs \ | ||
| --lf |
There was a problem hiding this comment.
Please use long option names in our examples: --last-failed, --verbose, --capture=no.
|
|
||
| source concent-env.sh | ||
| ./full-check.sh | ||
| ./api-e2e-tests.sh |
There was a problem hiding this comment.
Please allow passing the cluster address to api-e2e-tests.sh.
| @@ -536,6 +536,12 @@ Updates Concent to the version (tag/branch/commit) specified in the first parame | |||
| - Installs Concent dependencies in the virtualenv. | |||
| - Migrates the databases. | |||
|
|
|||
| ###### `concent-run-all-tests.sh` | |||
| This script run all concent tests, before execute, you must run the `concent-run.sh` script in a second console. | |||
There was a problem hiding this comment.
Please reword:
This script runs all of Concent's tests.
The only parameter is the address of a Concent cluster.
If not specified, it will try to connect to Concent running inside the machine.
You need to have a Concent server and its workers running in that case.
You can start it by executing `concent-run.sh` in another terminal session.| @@ -567,6 +573,20 @@ You can see all the available `golemapp` options by running: | |||
| golem-run-console-mode.sh --help | |||
| ``` | |||
|
|
|||
| ###### `golem-run-concent-integration-tests.sh` | |||
| Starts Golem integration tests for concent. | |||
| scripts/concent_acceptance_tests/force_accept \ | ||
| --maxfail=1 \ | ||
| -vs \ | ||
| --lf |
There was a problem hiding this comment.
I think this script should have some defaults. By default it should runn all the integration tests with the options you specified above (if those are the options we usually use).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.