-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add information about privileges for service accounts #382
base: master
Are you sure you want to change the base?
Add information about privileges for service accounts #382
Conversation
1058c38
to
ba161ba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here are a few remarks, mostly about formatting.
More importantly, I've pushed two commits that reorganize your explanation to make it easier to understand. Please look at it, try it, and tell me if you found any errors.
- Creating and deleting resources within a cluster (pods, services, config maps, etc.). | ||
- Creating and deleting schemas, tables and other items inside a PostgreSQL database on a Cloud SQL instance (but not the database or the instance itself). | ||
- Attaching storage to cluster pods. | ||
- Configuring a load balancer inside the cluster and attaching a static IP to it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This three points above are control by cluster service account. You should consider deleted they from concent-deployer
description.
README.md
Outdated
|
||
``` bash | ||
gcloud beta iam service-accounts create \ | ||
"$deployer_service_account" \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This command need only name of service_account without @$project_name.iam.gserviceaccount.com
e34c52f
to
5f2e747
Compare
5f2e747
to
39f10aa
Compare
|
39f10aa
to
db76ed4
Compare
Resolves #368