Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposed Ray PR changes #142

Conversation

cryptobench
Copy link
Member

  1. I've added an informational alert to emphasize that "yagna" is tightly integrated with this package.

  2. I've also decided to remove the alert about the virtual environment (venv). My reasoning is:

  • Users who are familiar with setting up venvs and want to use them will naturally do so without needing a prompt.
  • Those who don't usually set up venvs won't suddenly start just because of a brief alert. If we provided detailed instructions on how to do it, then there might have been a chance - but it might also overcomplicate the article.

Copy link

vercel bot commented Oct 31, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
golem-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2023 11:01pm

@mateuszsrebrny
Copy link
Contributor

Thank you, I am pulling yagna info - I didn't know how to put it - the info sounds great.

But I am keeping the venv - I got two explicit feedbacks that venv recommendation should be more visible - one said they know how to do it, but didn't think in the heat of ray on Golem excitement :)

I agree that people who don't know how might get startled... I will think about it (maybe would add a link to venv creation instructions?), but for now I would keep it.

@mateuszsrebrny mateuszsrebrny merged commit bc4366e into mateusz/ray-yagna-n-websocat-as-pip-dependencies Oct 31, 2023
3 checks passed
@mateuszsrebrny mateuszsrebrny deleted the proposed-changes-ray-pr branch December 5, 2023 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants