add promissory notes to TaskToCompute and SubtaskResultsVerify #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* raise informative exception when sig is misformatted
Codecov Report
@@ Coverage Diff @@
## master #338 +/- ##
==========================================
+ Coverage 94.73% 94.78% +0.05%
==========================================
Files 30 31 +1
Lines 2145 2204 +59
==========================================
+ Hits 2032 2089 +57
- Misses 113 115 +2 |
jiivan
reviewed
Apr 25, 2019
tworec
reviewed
Apr 25, 2019
Krigpl
reviewed
Apr 25, 2019
we never actually need the promissory note itself outside of the message... we need either to _sign_ it or to verify it but it suffices that the message itself knows its contents ...
…ages into promissory-notes
jiivan
previously approved these changes
Apr 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #328
closes: #329
closes: #330
closes: #331