Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update SDK with Holesky as a Default Network #2994

Closed
golmek opened this issue Jan 16, 2024 · 8 comments · Fixed by golemfactory/golem-core-python#136, golemfactory/golem-js#801, golemfactory/yapapi#1154 or golemfactory/golem-js#816
Closed

Update SDK with Holesky as a Default Network #2994

golmek opened this issue Jan 16, 2024 · 8 comments · Fixed by golemfactory/golem-core-python#136, golemfactory/golem-js#801, golemfactory/yapapi#1154 or golemfactory/golem-js#816
Assignees
@kamirr

Comments

@golmek
Copy link
Contributor

golmek commented Jan 16, 2024 •
edited
Loading

Update SDK to use Holesky as a Default Network:

  • Python (Core +Yapapi)
  • JS

should be done after: #3023
@kamirr kamirr self-assigned this Jan 31, 2024
This was linked to pull requests Feb 13, 2024
temp: set yagna tag to pre-rel-v0.15.0-rc14 golemfactory/goth#667
Closed
Kek/default holesky golemfactory/golem-core-python#136
Merged
feat(payments): change default network to holesky golemfactory/golem-js#801
Merged
@golmek
Copy link
Contributor Author

golmek commented Feb 13, 2024

IN PROGRESS:

  • Yapapi
  • CI: How to make it work with our RC instead of upstream Yagna (not compatible)

@golmek
Copy link
Contributor Author

golmek commented Feb 14, 2024

Python SDK's does not work on Goth - investigation in progress

TO DO:

  • talk with Grisha to figure out why tests are done on Goerli instead of Holesky

@golmek
Copy link
Contributor Author

golmek commented Feb 21, 2024

Status:

  • JS works
  • Python Core - In progress
  • Yapapi - In progress

TODO:

  • ask SDK team to move SDK tests on RC

@kamirr kamirr reopened this Feb 23, 2024
@kamirr kamirr linked a pull request Feb 23, 2024 that will close this issue
engine: change default network to holesky golemfactory/yapapi#1154
Merged
@golmek
Copy link
Contributor Author

golmek commented Feb 23, 2024 •
edited
Loading

JS - works but will be merged after release
Python (Core + Yapapi) - works but to be merged after release

@golmek
Copy link
Contributor Author

golmek commented Feb 23, 2024

Blocked till release

@kamirr kamirr linked a pull request Feb 23, 2024 that will close this issue
Kek/holesky golemfactory/golem-js#816
Merged
@golmek
Copy link
Contributor Author

golmek commented Apr 25, 2024

Review done by @shadeofblue

@kamirr
Copy link
Contributor

kamirr commented May 6, 2024

blue is ooo until tomorrow

@kamirr kamirr reopened this May 13, 2024
@golmek
Copy link
Contributor Author

golmek commented May 20, 2024

Ping @shadeofblue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kamirr kamirr

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@kamirr @golmek