Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

engine: change default network to holesky #1154

Merged
merged 1 commit into from
May 22, 2024
Merged

Conversation

kamirr
Copy link
Contributor

@kamirr kamirr commented Feb 23, 2024

No description provided.

@kamirr kamirr requested a review from a team as a code owner February 23, 2024 09:56
@kamirr kamirr linked an issue Feb 23, 2024 that may be closed by this pull request
@kamirr kamirr requested a review from shadeofblue April 24, 2024 05:27
@shadeofblue
Copy link
Contributor

but I guess it also requires a newer version of goth which defaults to holesky?

@kamirr kamirr force-pushed the kek/default-holesky branch 4 times, most recently from 9e29a29 to a0298cd Compare May 20, 2024 08:38
@kamirr
Copy link
Contributor Author

kamirr commented May 20, 2024

I've checked that the change works manually. I don't have cycles to fix CI right now, the issue is present on master as well.

Can somebody merge it as-is without CI passing? @shadeofblue ?

@shadeofblue shadeofblue merged commit 7ecbab7 into master May 22, 2024
12 of 16 checks passed
@shadeofblue shadeofblue deleted the kek/default-holesky branch May 22, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update SDK with Holesky as a Default Network
2 participants