Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCT-2263 Community onboarding through Sablier #600

Conversation

kgarbacinski
Copy link
Contributor

Description

Definition of Done

  1. If required, the desciption of your change is added to the QA changelog
  2. Acceptance criteria are met.
  3. PR is manually tested before the merge by developer(s).
    • Happy path is manually checked.
  4. PR is manually tested by QA when their assistance is required (1).
    • Octant Areas & Test Cases are checked for impact and updated if required (2).
  5. Unit tests are added unless there is a reason to omit them.
  6. Automated tests are added when required.
  7. The code is merged.
  8. Tech documentation is added / updated, reviewed and approved (including mandatory approval by a code owner, should such exist for changed files).
    • BE: Swagger documentation is updated.
  9. When required by QA:
    • Deployed to the relevant environment.
    • Passed system tests.

(1) Developer(s) in coordination with QA decide whether it's required. For small tickets introducing small changes QA assistance is most probably not required.

(2) Octant Areas & Test Cases.

Copy link

linear bot commented Dec 20, 2024

Copy link
Member

@aziolek aziolek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It needs to wait for FE part here.

@jmikolajczyk
Copy link
Contributor

/deploy

@housekeeper-bot housekeeper-bot temporarily deployed to uat January 15, 2025 10:27 Destroyed
@housekeeper-bot housekeeper-bot temporarily deployed to uat January 15, 2025 14:47 Destroyed
@housekeeper-bot housekeeper-bot temporarily deployed to uat January 15, 2025 15:06 Destroyed
@housekeeper-bot housekeeper-bot temporarily deployed to uat January 16, 2025 12:23 Destroyed
@housekeeper-bot housekeeper-bot temporarily deployed to uat January 17, 2025 08:08 Destroyed
@housekeeper-bot housekeeper-bot temporarily deployed to uat January 27, 2025 10:50 Destroyed
@housekeeper-bot housekeeper-bot temporarily deployed to uat January 28, 2025 07:36 Destroyed
@housekeeper-bot housekeeper-bot temporarily deployed to uat January 28, 2025 08:15 Destroyed
@housekeeper-bot housekeeper-bot temporarily deployed to uat January 28, 2025 15:51 Destroyed
@kgarbacinski kgarbacinski changed the title OCT-2263: Community onboarding through Sablier OCT-2263 & OCT-2286: Community onboarding through Sablier & Adjust metrics for Sablier Feb 5, 2025
Copy link

linear bot commented Feb 5, 2025

aziolek
aziolek previously approved these changes Feb 7, 2025
@aziolek
Copy link
Member

aziolek commented Feb 7, 2025

I approve FE part (what @jmikolajczyk did) without what I did in 09105ef & 5907b8e.

@jmikolajczyk: please check and let me know if it requires any adjustments.

aziolek
aziolek previously approved these changes Feb 7, 2025
@jmikolajczyk
Copy link
Contributor

I approve FE part (what @jmikolajczyk did) without what I did in 09105ef & 5907b8e.

@jmikolajczyk: please check and let me know if it requires any adjustments.

@aziolek LGTM 👍

@aziolek aziolek added the request-approval Request approval from the Housekeeper label Feb 7, 2025
@aziolek aziolek changed the title OCT-2263 & OCT-2286: Community onboarding through Sablier & Adjust metrics for Sablier OCT-2263 Community onboarding through Sablier Feb 7, 2025
@aziolek
Copy link
Member

aziolek commented Feb 7, 2025

I changed the title of this PR to reflect regrouping of tickets in Linear.

@housekeeper-bot housekeeper-bot temporarily deployed to uat February 7, 2025 13:55 Destroyed
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Feb 7, 2025
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #13199437946 passed 🎉

Copy link
Contributor

@MateuszStoleckiGLM MateuszStoleckiGLM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for release and deployment

@MateuszStoleckiGLM MateuszStoleckiGLM merged commit 304ec59 into develop Feb 13, 2025
31 checks passed
@MateuszStoleckiGLM MateuszStoleckiGLM deleted the kacper/feat/oct-2263-community-onboarding-through-sablier branch February 13, 2025 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants