Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GetEpisodeByID and GetEpisodeByIDContext to Sonarr client #115

Merged
merged 2 commits into from
Jun 4, 2023

Conversation

rtrox
Copy link
Contributor

@rtrox rtrox commented Jun 4, 2023

Per Title -- this PR adds GetEpisodeByID & Context variant. Tested locally, I'm able to collect an Episode by it's ID.

Signed-off-by: Russell Troxel <russelltroxel@gmail.com>
@davidnewhall
Copy link
Contributor

davidnewhall commented Jun 4, 2023

You want to try to put together a test? Bummer that file has no examples to copy/paste. :(

Signed-off-by: Russell Troxel <russelltroxel@gmail.com>
@rtrox
Copy link
Contributor Author

rtrox commented Jun 4, 2023

Yep, np -- Just pushed an updated Commit with the added tests.

All tests pass:

go test ./...
?       golift.io/starr/debuglog        [no test files]
ok      golift.io/starr (cached)
ok      golift.io/starr/lidarr  (cached)
ok      golift.io/starr/prowlarr        (cached)
ok      golift.io/starr/radarr  (cached)
ok      golift.io/starr/readarr (cached)
?       golift.io/starr/starrtest       [no test files]
ok      golift.io/starr/sonarr  (cached)
ok      golift.io/starr/starrcmd        (cached)

And specific tests output:

=== RUN   TestGetEpisodeByID
=== PAUSE TestGetEpisodeByID
=== CONT  TestGetEpisodeByID
=== RUN   TestGetEpisodeByID/200
=== PAUSE TestGetEpisodeByID/200
=== RUN   TestGetEpisodeByID/404
=== PAUSE TestGetEpisodeByID/404
=== CONT  TestGetEpisodeByID/200
=== CONT  TestGetEpisodeByID/404
--- PASS: TestGetEpisodeByID (0.00s)
    --- PASS: TestGetEpisodeByID/404 (0.00s)
    --- PASS: TestGetEpisodeByID/200 (0.00s)

Let me know if this works! Thanks.

@davidnewhall
Copy link
Contributor

quick quick, thank you for your contribution!

@davidnewhall davidnewhall merged commit 504c41a into golift:main Jun 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants