feat: add tag resources #32
Conversation
Fuochi
commented
Feb 4, 2022
Fuochi
commented
- add GetTag
- add DeleteTag
- add Tag methods for Prowlarr (not very useful)
- edit UpdateTag to be aligned with api docs
|
|
||
| // UpdateTagContext updates the label for a tag. | ||
| func (p *Prowlarr) UpdateTagContext(ctx context.Context, tagID int, label string) (int, error) { | ||
| body, err := json.Marshal(&starr.Tag{Label: label, ID: tagID}) |
| } | ||
|
|
||
| // UpdateTag updates the label for a tag. | ||
| func (p *Prowlarr) UpdateTag(tagID int, label string) (int, error) { |
There was a problem hiding this comment.
Is Prowlarr the only one with update?
There was a problem hiding this comment.
no, the others already had update, I just changed it to add the ID. It works even without it, but in all api docs but sonarr's the ID is in the definition (e.g. https://radarr.video/docs/api/#/Tag/put-tag-id)
There was a problem hiding this comment.
Gotcha, cool. I think something I wrote uses update tag, and it's been around a while so I never made it back there to the rest of the methods.
|
I'll cut a new release in the next couple weeks. Got a few other changes that are pending testing. Feel free to add anything else you need. |
|
Thanks! I really like this work, I'll try few things with the tags. Once I finished, I'll probably contribute more! But it could take me a while. btw, do you have in plan to write any unit tests? |
|
I'd love tests, I suppose I could start a few and get a base going at least. I'm just lazy on this one. :) Thanks again! |
|
fwiw, I started some tests. If you have feedback on where I'm going with those, I'm all ears. |
