Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sonarr): add notification #64

Merged
merged 3 commits into from
Oct 19, 2022
Merged

feat(sonarr): add notification #64

merged 3 commits into from
Oct 19, 2022

Conversation

Fuochi
Copy link
Contributor

@Fuochi Fuochi commented Sep 22, 2022

  • add notification

davidnewhall
davidnewhall requested changes Sep 22, 2022
View reviewed changes
sonarr/notification.go
Implementation string `json:"implementation"`
ConfigContract string `json:"configContract"`
Tags []int `json:"tags"`
Fields []*starr.FieldInput `json:"fields"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sure glad this works.

sonarr/notification.go Outdated Show resolved Hide resolved
sonarr/notification.go Outdated Show resolved Hide resolved
sonarr/notification.go Outdated Show resolved Hide resolved
@davidnewhall
Copy link
Contributor

Godsend if you add this to the others and close #62. 💚

@Fuochi Fuochi mentioned this pull request Sep 22, 2022
Merged
@Fuochi Fuochi force-pushed the feature/sonarr-notification branch from 5e8dd06 to 5bad26b Compare September 27, 2022 11:22
@Fuochi
Copy link
Contributor Author

Fuochi commented Sep 27, 2022

Godsend if you add this to the others and close #62. 💚

I've few more branches locally that I have to push before starting working on something else, maybe around end of october?

davidnewhall
davidnewhall reviewed Oct 7, 2022
View reviewed changes
sonarr/notification_test.go Outdated
`"onSeriesDelete":false,"onEpisodeFileDelete":true,"onEpisodeFileDeleteForUpgrade":false,` +
`"onHealthIssue":false,"onApplicationUpdate":false,"includeHealthWarnings":false,"id":3,"name":"Test",` +
`"implementation":"CustomScript","configContract":"CustomScriptSettings","tags":null,` +
`"fields":[{"name":"path","value":"/scripts/sonarr.sh"},{"name":"apiPath","value":"/api"}]}`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a lot of damn work.

@Fuochi Fuochi force-pushed the feature/sonarr-notification branch from 5bad26b to d213040 Compare October 11, 2022 09:44
@Fuochi
Copy link
Contributor Author

Fuochi commented Oct 11, 2022

so... I changed back the omitempty tag to be used with booleans as well, during my last review I noticed that I was mistaken when I thought that those fields aren't working. we just have to remember that missing=false, even for PUT.

This should work. Unfortunately I won't have much time in the next weeks to help you with this project. If you're ok, we can start by merging this, then we'll see for the other *arrs

davidnewhall
davidnewhall approved these changes Oct 11, 2022
View reviewed changes
Copy link
Contributor

@davidnewhall davidnewhall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with this. We can iron out problems later. I'll be using this code soon enough to update naming profiles in the wild.

@Fuochi Fuochi merged commit bbd3bf6 into master Oct 19, 2022
@Fuochi Fuochi deleted the feature/sonarr-notification branch October 19, 2022 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidnewhall davidnewhall davidnewhall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Fuochi @davidnewhall