Update system/status structs

[davidnewhall]

Closes #67.

Updates and alphabetizes structs for system/status.

[Fuochi]

just 2 notes:
1- please think about start writing tests, they'll save a lot of time
2- why alphabetic order for struct fields? lately, I've been thinking that we could try to lower the memory usage by sorting using fieldalignment or something similar. what do you think?

[davidnewhall]

Alphabetical seems like it makes it easy to identify changes. But I also agree it's irrational given how Go stores structures in memory.

I'll start putting tests in for any new methods.

[davidnewhall]

I played with this for a bit. Does not seem to matter what order I put the fields in, the Lidarr struct is always 328 bytes. Try it: https://go.dev/play/p/4zrxs5qm8Ir

Maybe t's just that struct, but I'm not seeing an easy win here. :(

[Fuochi]

I played with this for a bit. Does not seem to matter what order I put the fields in, the Lidarr struct is always 328 bytes. Try it: https://go.dev/play/p/4zrxs5qm8Ir

Maybe t's just that struct, but I'm not seeing an easy win here. :(

yes, since all fields but bool are multiple of 8 bytes, and there are 9 bool, the only way to have a bigger struct is to have 3 or more groups of bools (https://go.dev/play/p/d18Fu0jxx2d) I think that putting time.Time at first and string to follow should optimize a bit the runtime usage, but honestly, I didn't fully get how... more findings here: 1pkg/gopium#24 (comment)

However, if there really is an improvement, we're talking about minimal. Hence, feel free do do as you prefer.
The only real benefit that comes to my mind: If we use fieldalignment -fix and let it decide the order of the fields, we'll have consistency across the code, no matter who writes it.

[davidnewhall]

Can you link me to the fieldalignment tool you mentioned?
EDIT:
This one?

go install golang.org/x/tools/go/analysis/passes/fieldalignment/cmd/fieldalignment

EDIT2:
Weird..

src/golift.io/starr$ fieldalignment -v golift.io/starr/radarr
fieldalignment: internal error: package "bytes" without types was imported from "golift.io/starr/radarr"

src/golift.io/starr$ fieldalignment -v golift.io/starr/prowlarr
fieldalignment: internal error: package "strings" without types was imported from "golift.io/starr/prowlarr"

src/golift.io/starr$ fieldalignment -v golift.io/starr/starrcmd
fieldalignment: internal error: package "fmt" without types was imported from "golift.io/starr/starrcmd"

[Fuochi]

sure, package is: https://pkg.go.dev/golang.org/x/tools/go/analysis/passes/fieldalignment
usage:

go install golang.org/x/tools/go/analysis/passes/fieldalignment/cmd/fieldalignment@latest
fieldalignment -fix ./

it could be enabled as linter as well as part of govet in golangci:

linters-settings:
  govet:
    enable:
      - fieldalignment

[Fuochi]

btw, it's really a small thing, don't waste too much time here

[davidnewhall]

lidarr/system.go:15:19: fieldalignment: struct with 320 pointer bytes could be 296 (govet)
type SystemStatus struct {

[davidnewhall]

I can only get this to work through golangci-lint, and not by running it directly I suspect I have a library out of date, but not sure how to fix it.

[davidnewhall]

I'm just going to worry about optimizing the structs later; there's hundreds that need fixing, and I can't get this dang tool to work right.