Add Calendar methods: sonarr & readarr #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidnewhall
commented
Oct 8, 2022
| } | ||
|
|
||
| // BookAuthor of a Book. | ||
| type BookAuthor struct { |
There was a problem hiding this comment.
This was removed and replaced by Book.
| Images []*starr.Image `json:"images"` // this is dumb too | ||
| ForeignEditionID string `json:"foreignEditionId"` // GRID ID | ||
| Monitored bool `json:"monitored"` // true | ||
| ManualAdd bool `json:"manualAdd"` // true | ||
| } | ||
|
|
||
| // AddBookOutput is returned when a book is added. | ||
| type AddBookOutput struct { |
There was a problem hiding this comment.
This was removed and replaced by Book.
| HasFile bool `json:"hasFile"` | ||
| Monitored bool `json:"monitored"` | ||
| Images []*starr.Image `json:"images"` | ||
| Series *Series `json:"series"` |
There was a problem hiding this comment.
I'm not sure how this was ever missed... maybe it was added later?
davidnewhall
changed the title
Fuochi
approved these changes
Oct 11, 2022
|
Tested this more and found that the pointers were pointless. Removed them. Merged master. Caught a mistake in the last PR and fixed that. Good to go now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes half of #66. I'm only going to do Sonarr and Readarr in this 1 PR to keep it smaller. Will make another one for the other two apps.
Cleans up
Book,Author, andEpisodetypes. Probably easier to look at without white-space changes: https://github.com/golift/starr/pull/71/files?w=1