Fix radarr movie types. #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidnewhall
commented
Oct 8, 2022
| } | ||
|
|
||
| // OpenRatings is a ratings type that has a source and type. | ||
| type OpenRatings map[string]Ratings |
There was a problem hiding this comment.
From the /api/v3/movie endpoint came this cool payload...
"ratings": {
"imdb": {
"votes": 16719,
"value": 5.6,
"type": "user"
},
"tmdb": {
"votes": 566,
"value": 7,
"type": "user"
},
"metacritic": {
"votes": 0,
"value": 54,
"type": "user"
},
"rottenTomatoes": {
"votes": 0,
"value": 69,
"type": "user"
}
}| @@ -118,53 +123,17 @@ type AddMovieOptions struct { | |||
| SearchForMovie bool `json:"searchForMovie"` | |||
| } | |||
|
|
|||
| // AddMovieOutput is the data returned when adding a movier. | |||
| type AddMovieOutput struct { | |||
There was a problem hiding this comment.
The only difference between this and Movie was the AddOptions member. I went ahead and added that to Movie.
Comment on lines
+55
to
+56
| Popularity float64 `json:"popularity"` | ||
| OriginalLanguage *starr.Value `json:"originalLanguage,omitempty"` |
There was a problem hiding this comment.
"originalFilePath": "Beast.2022.1080p.AMZN.WEBRip.DD5.1.X.264-EVO/Beast.2022.1080p.AMZN.WEBRip.DD5.1.X.264-EVO.mkv",
"popularity": 2240.269,
| @@ -91,6 +95,7 @@ type MediaInfo struct { | |||
| VideoBitrate int `json:"videoBitrate"` | |||
| VideoCodec string `json:"videoCodec"` | |||
| VideoFps float64 `json:"videoFps"` | |||
| VideoDynamicRangeType string `json:"videoDynamicRangeType"` | |||
There was a problem hiding this comment.
This was a blank string on the movie I looked at.
"videoDynamicRangeType": "",
| VoteCount int `json:"voteCount"` | ||
| Language *starr.Value `json:"language"` | ||
| ID int `json:"id"` | ||
| MovieMetadataID int64 `json:"movieMetadataId"` |
There was a problem hiding this comment.
"alternateTitles": [
{
"sourceType": "tmdb",
"movieMetadataId": 2671,
"title": "Zvērs",
"sourceId": 0,
"votes": 0,
"voteCount": 0,
"language": {
"id": 1,
"name": "English"
},
"id": 18219
},
{
"sourceType": "tmdb",
"movieMetadataId": 2671,
"title": "La Bestia",
"sourceId": 0,
"votes": 0,
"voteCount": 0,
"language": {
"id": 3,
"name": "Spanish"
},
"id": 18220
},
{
"sourceType": "tmdb",
"movieMetadataId": 2671,
"title": "جانور",
"sourceId": 0,
"votes": 0,
"voteCount": 0,
"language": {
"id": 1,
"name": "English"
},
"id": 18221
},
{
"sourceType": "tmdb",
"movieMetadataId": 2671,
"title": "Žvėris",
"sourceId": 0,
"votes": 0,
"voteCount": 0,
"language": {
"id": 24,
"name": "Lithuanian"
},
"id": 18330
}
Fuochi
approved these changes
Oct 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a few missing fields, fixes
ratingsfield in Movie type. ReplacesAddMovieOutputwithMovieand adds a proper output toUpdateMovie().