-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: download client #81
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. I would recommend putting RemotePathMapping
in starr
. Having shared types can make downstream apps easier to reason about (common interfaces ftw).
85c0ba1
to
3ff5629
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Since remotepathmapping is the same in each arr, we can put the struct definition in the starr package. @davidnewhall what do you think? should we keep each file separate, or should we group the struct definition in one place?
the other 2 resources change a bit between different arr