Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: download client #81

Merged
merged 11 commits into from
Nov 21, 2022
Merged

feat: download client #81

merged 11 commits into from
Nov 21, 2022

Conversation

Fuochi
Copy link
Contributor

@Fuochi Fuochi commented Nov 16, 2022

  • add downloadclientconfig (radarr,readarr,lidarr)
  • add remotepathmapping (radarr,readarr,lidarr)
  • add downloadclient (radarr,readarr,lidarr,prowlarr)

Since remotepathmapping is the same in each arr, we can put the struct definition in the starr package. @davidnewhall what do you think? should we keep each file separate, or should we group the struct definition in one place?

the other 2 resources change a bit between different arr

Copy link
Contributor

@davidnewhall davidnewhall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. I would recommend putting RemotePathMapping in starr. Having shared types can make downstream apps easier to reason about (common interfaces ftw).

@Fuochi Fuochi force-pushed the feature/downloadclient branch from 85c0ba1 to 3ff5629 Compare November 17, 2022 05:41
@Fuochi Fuochi requested a review from davidnewhall November 17, 2022 10:47
Copy link
Contributor

@davidnewhall davidnewhall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Fuochi Fuochi merged commit 7260aa0 into master Nov 21, 2022
@Fuochi Fuochi deleted the feature/downloadclient branch November 21, 2022 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants