feat: indexer #86
Merged
feat: indexer #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidnewhall
requested changes
Nov 30, 2022
davidnewhall
approved these changes
Dec 2, 2022
Nothing specific, but I have a feeling that it could be improved since indexers are the main object of prowlarr, I made just few tests which probably don't cover all the use cases. Also, more methods can be added later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First two were pretty straightforward, I hope I haven't missed anything.
For the latest, I tried to run simple test and it worked. However, I think that if we merge this, we'll have to work again on prowlarr's indexer in the future.
If you don't like the prowlarr code, I can remove it from this PR.