Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make 'env.Timeout' more specific #261

Closed
arschles opened this issue Jul 13, 2018 · 1 comment · Fixed by #627
Closed

Make 'env.Timeout' more specific #261

arschles opened this issue Jul 13, 2018 · 1 comment · Fixed by #627
Labels
enhancement New feature or request good first issue Great issues for new Athenians to work on! refactor work to do to refactor code

Comments

@arschles
Copy link
Member

I think we should have separate timeouts for different services. For example, mongo connection timeouts (see #216), HTTP timeouts, etc...

Continuation of #254 (comment)
@arschles arschles mentioned this issue Jul 13, 2018
Merged
@ghost
Copy link

ghost commented Jul 13, 2018

Agreed, I thought that as well but forgot to create the follow up.

Web requests and DB connections should have more sane defaults, maybe 60s?

@ghost ghost added enhancement New feature or request good first issue Great issues for new Athenians to work on! refactor work to do to refactor code labels Jul 14, 2018
@rohancme rohancme mentioned this issue Aug 10, 2018
Merged
@rohancme rohancme mentioned this issue Aug 19, 2018
Closed
@rohancme rohancme mentioned this issue Sep 4, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Great issues for new Athenians to work on! refactor work to do to refactor code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Plumb config - Latest rohancme/athens
1 participant
@arschles