-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plumb config #517
Plumb config #517
Conversation
Codecov Report
@@ Coverage Diff @@
## master #517 +/- ##
==========================================
+ Coverage 41.2% 45.03% +3.83%
==========================================
Files 99 97 -2
Lines 2830 2782 -48
==========================================
+ Hits 1166 1253 +87
+ Misses 1554 1409 -145
- Partials 110 120 +10
Continue to review full report at Codecov.
|
Also resolving conflicts in this PR is going to be SUPER annoying :) I'll probably do a squash and rebase after reviews |
Might i suggest a squash and rebase first? That way we can start clean now that the config file PR is done. |
i'm also leaning towards rebase-review order. In case of rebase just ping us directly and we can put priority into reviewing this and not pushing anything else in |
Working on this today. I'll attempt a squash + rebase but there are so many conflicts I might just start afresh. |
@robjloranger @michalpristas closing this in favor of #627 . There were simply too many merge conflicts. This also forced me to get caught up with the latest changes :) |
This PR is a continuation of #453
It should resolve #190, #284 and to some extent #261. I've plumbed timeouts through wherever implemented.
Files that are deleted in this PR are due to changes being made in #511 and #513 (Removing pop from storage and removing olympus as a storage implementation), so ideally this should be merged only after those changes have been approved and merged.