remove olympus storage implementation and proxy worker #513
Conversation
Codecov Report
@@ Coverage Diff @@
## master #513 +/- ##
==========================================
+ Coverage 40.23% 40.56% +0.33%
==========================================
Files 101 100 -1
Lines 3127 3057 -70
==========================================
- Hits 1258 1240 -18
+ Misses 1742 1693 -49
+ Partials 127 124 -3
Continue to review full report at Codecov.
|
|
please resolve conflicts @rchakra3 |
cmd/proxy/actions/filter.go
Outdated
| "github.com/gomods/athens/pkg/errors" | ||
| "github.com/gomods/athens/pkg/module" | ||
| "github.com/gomods/athens/pkg/paths" | ||
| ) | ||
|
|
||
| const ( | ||
| // OlympusGlobalEndpoint is a default olympus DNS address | ||
| OlympusGlobalEndpoint = "http://localhost:3001" |
There was a problem hiding this comment.
Is this file changed by mistake? this seems out of scope (and already addressed in another PR if im not mistaken)
There was a problem hiding this comment.
it migrates const from removed file
| }, | ||
| }, | ||
| Name: FetcherWorkerName, | ||
| MaxConcurrency: env.AthensMaxConcurrency(), |
There was a problem hiding this comment.
you need to remove this as well from config package
There was a problem hiding this comment.
sorry still used in olympus
|
|
||
| opts := work.JobOptions{ | ||
| SkipDead: true, | ||
| MaxFails: env.WorkerMaxFails(), |
There was a problem hiding this comment.
sorry still used in olympus
|
@marwan-at-work I think your comments aren't applicable after moving the middleware to pkg/ @michalpristas resolved conflicts! |
cmd/proxy/actions/app.go
Outdated
| store, err := GetStorage() | ||
|
|
There was a problem hiding this comment.
can you please remove space?
|
@marwan-at-work can you please review once more. this is a quick one |
Addresses #414
The only worker in the proxy was set up to asynchronously pull from olympus on cache misses. I've deleted all that code in addition to the olympus storage module. As mentioned in #414 if we want to bring back the async download functionality, we can implement a new
download.Protocolfor olympus