Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove olympus package from pkg/storage #414

Closed
marwan-at-work opened this issue Aug 5, 2018 · 4 comments
Closed

Remove olympus package from pkg/storage #414

marwan-at-work opened this issue Aug 5, 2018 · 4 comments
Labels
good first issue Great issues for new Athenians to work on!

Comments

@marwan-at-work
Copy link
Contributor

From #309 and #349, it looks like we're never gonna use Olympus as a storage backend to Proxy. We either redirect to Olympus, or use it as a download.Protocol interface in which case we save to storage first then stream back from storage.
@michalpristas michalpristas added the good first issue Great issues for new Athenians to work on! label Aug 5, 2018
@VineethReddy02
Copy link

I would like to work on this. How should i get onto this ?

@michalpristas
Copy link
Member

@VineethReddy02
there is a package /pkg/storage/olympus which needs to be removed
then in each storage generation you need to revisit switch cases and remove olympus case together with any other olympus storage reference. build (or go vet ./...) will fail so it will be easy

@rohancme rohancme mentioned this issue Aug 18, 2018
Merged
@adyach
Copy link
Contributor

adyach commented Aug 22, 2018

@VineethReddy02 are you still on that? if not I would like to grab it

@adyach
Copy link
Contributor

adyach commented Aug 22, 2018

sorry it was already addressed in #513

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Great issues for new Athenians to work on!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@michalpristas @adyach @marwan-at-work @VineethReddy02