Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the fetch route, handler & gomod parser #312

Closed
arschles opened this issue Jul 20, 2018 · 3 comments
Closed

Remove the fetch route, handler & gomod parser #312

arschles opened this issue Jul 20, 2018 · 3 comments
Labels
proposal A proposal for discussion and possibly a vote

Comments

@arschles
Copy link
Member

The fetch route is here and the handler is here

This handler was used by the CLI (which is obsolete and was removed), and we don't need it anymore. This issue is for removing the fetch handler, the fetch route, and the gomod parser which was used by the fetch handler

@arschles arschles added the proposal A proposal for discussion and possibly a vote label Jul 20, 2018
arschles added a commit to arschles/athens that referenced this issue Jul 20, 2018
@ryancox
Copy link

ryancox commented Jul 20, 2018

is there a gomod parser library elsewhere that could be used / improved?

@arschles
Copy link
Member Author

@ryancox yes, it's in a package inside golang/go, I think an internal package. We're going to delegate as much of this as possible to calling the go CLI so we don't have to depend on code inside of the go toolchain

cc/ @rsc @marwan-at-work, both of whom have been part of discussions on this topic

@arschles
Copy link
Member Author

This is a subset of #335, closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proposal A proposal for discussion and possibly a vote
Projects
None yet
Development

No branches or pull requests

2 participants