Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: remove commit hash from known limitations #1019

Merged
merged 5 commits into from
Jan 15, 2019
Merged

docs: remove commit hash from known limitations #1019

merged 5 commits into from
Jan 15, 2019

Conversation

marwan-at-work
Copy link
Contributor

once #1015 is merged, this is no longer a limitation.

@marwan-at-work marwan-at-work requested a review from a team as a code owner December 27, 2018 18:09
@codecov-io
Copy link

codecov-io commented Dec 27, 2018 •
edited
Loading

Codecov Report

Merging #1019 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1019   +/-   ##
======================================
  Coverage    56.7%   56.7%           
======================================
  Files          81      81           
  Lines        2686    2686           
======================================
  Hits         1523    1523           
  Misses       1026    1026           
  Partials      137     137

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 025fe91...8bf9f95. Read the comment docs.

@marpio
Copy link
Member

marpio commented Jan 3, 2019 •
edited
Loading

@marwan-at-work should we wait with it until go1.12 or at least mention that it will work only with 1.12 ?

@marwan-at-work
Copy link
Contributor Author

@marpio it doesn't hurt to merge #1015 before 1.12, but yeah for this PR it might be good to mention that hashes and branches only work with 1.12+

@ghost ghost added the blocked This issue or pull request requires one or more other issues or pull requests before completion. label Jan 4, 2019
@marwan-at-work marwan-at-work removed the blocked This issue or pull request requires one or more other issues or pull requests before completion. label Jan 8, 2019
arschles
arschles approved these changes Jan 15, 2019
View reviewed changes
Copy link
Member

@arschles arschles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@marpio marpio merged commit b17bfb3 into gomods:master Jan 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marpio marpio marpio approved these changes

@arschles arschles arschles approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marwan-at-work @codecov-io @marpio @arschles