[WIP]Remove rdbms storage from pkg/storage #502
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #502 +/- ##
==========================================
+ Coverage 41.64% 42.59% +0.94%
==========================================
Files 98 92 -6
Lines 2802 2709 -93
==========================================
- Hits 1167 1154 -13
+ Misses 1527 1447 -80
Partials 108 108
Continue to review full report at Codecov.
|
|
can you fill in description with: Why, how... |
michalpristas
approved these changes
Aug 17, 2018
marpio
approved these changes
Aug 17, 2018
ghost
approved these changes
Aug 17, 2018
- Not sourcing from cmd/proxy/.env, because that doesn't export any variables - Removing mysql support (I feel like 1 database is enough) - Pruning networks on teardown I'm happy to split these changes up into separate PRs - it's the end of the day for me so I wanted to get everything in 😄
manugupt1
changed the title
|
Removing docker required a whole lot of changes. Addressed at #511 |
| @@ -34,12 +33,6 @@ func GetStorage() (storage.Backend, error) { | |||
| return nil, err | |||
| } | |||
| return mongo.NewStorage(mongoURI) | |||
| case "postgres", "sqlite", "cockroach", "mysql": | |||
There was a problem hiding this comment.
we are removing postgres support but starting postrgres image. why is that?
|
Yep! sorry about that! the builds and tests succeeded only at #511 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #494