removing registry page #802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #802 +/- ##
=======================================
Coverage 57.44% 57.44%
=======================================
Files 76 76
Lines 2437 2437
=======================================
Hits 1400 1400
Misses 913 913
Partials 124 124Continue to review full report at Codecov.
|
michalpristas
approved these changes
Oct 23, 2018
|
I think we should at least remove the links to registry.md from other files. |
|
@marpio @michalpristas thanks for catching all the registry references that I missed 😄 I made a lot of changes that I think removes everything related to the registry. I think things got clearer too Can you take another look when you have time? |
|
Thanks @marpio and @michalpristas for helping me so much here! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem I am trying to address?
The docs still had a page referring to the registry. We've decided that we're not trying to build a registry right now (see #772)
How is the fix applied?
I just removed the
docs/content/design/registry.mdpageMention the issue number it fixes or add the details of the changes if it doesn't has a specific issue.
Fixes #732