Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compilation fails for v1.9.1 in go1.16 environment #665

Closed
sanojsubran opened this issue Feb 24, 2024 · 1 comment · Fixed by #666
Closed

Compilation fails for v1.9.1 in go1.16 environment #665

sanojsubran opened this issue Feb 24, 2024 · 1 comment · Fixed by #666

Comments

@sanojsubran
Copy link

In the latest release v1.9.1, even though the mentioned version in go.mod file is 1.16, the compilation fails in a go1.16 env.

Output:

$ go test ./...
# github.com/stretchr/testify/assert
../../go/pkg/mod/github.com/stretchr/testify@v1.8.4/assert/assertions.go:94:23: field.IsExported undefined (type reflect.StructField has no field or method IsExported)
note: module requires Go 1.20
FAIL    github.com/gomodule/redigo/redis [build failed]
FAIL    github.com/gomodule/redigo/redisx [build failed]
FAIL

$ go version
go version go1.16.15 linux/amd64
@sanojsubran sanojsubran mentioned this issue Feb 24, 2024
Closed
@stevenh
Copy link
Collaborator

stevenh commented Feb 24, 2024 •
edited
Loading

Looks like we should update go.mod to require go 1.21 which is the oldest supported version of go.

stevenh added a commit that referenced this issue Feb 25, 2024
@stevenh
fix: bump go version to 1.17
0aab11a 
Due to our test dependency requiring 1.17 minimum and the 1.16 being
well out of support, currently only 1.21 and 1.22 are support releases,
bump our required go version to 1.16.

Fixes #665
@stevenh stevenh mentioned this issue Feb 25, 2024
Merged
stevenh added a commit that referenced this issue Feb 25, 2024
@stevenh
fix: bump go version to 1.17 (#666)
e05a63b 
Due to our test dependency requiring 1.17 minimum and the 1.16 being
well out of support, currently only 1.21 and 1.22 are support releases,
bump our required go version to 1.16.

Fixes #665
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: bump go version to 1.17 gomodule/redigo
2 participants
@stevenh @sanojsubran