Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change copyToRDRAM default when building with M64P_GLIDENUI #2835

Merged
merged 1 commit into from
May 1, 2024

Conversation

Rosalie241
Copy link
Contributor

Should fix all corruption when resizing the window for all games, because some users were still experiencing this issue

@GhostlyDark
Copy link
Contributor

Should this really be specific to M64P_GLIDENUI instead of being the default in general? Some games need it in the first place (which comes into play when per-game settings are turned off), though I have no idea how much it would impact performance out of the box.

@Rosalie241
Copy link
Contributor Author

Should this really be specific to M64P_GLIDENUI instead of being the default in general? Some games need it in the first place (which comes into play when per-game settings are turned off), though I have no idea how much it would impact performance out of the box.

I'm not sure, but the performance impact question is why I limited it to M64P_GLIDENUI

@gonetz
Copy link
Owner

gonetz commented May 1, 2024

I have no idea how much it would impact performance out of the box.

The impact is noticeable for games running in Hires mode, that is with internal resolution above 320x240.
I'd prefer to enable sync mode via custom game ini for safety. However, if Rosalie thinks that it should be default mode for M64P_GLIDENUI, ok.

@gonetz gonetz merged commit 576ad87 into gonetz:master May 1, 2024
10 checks passed
@Rosalie241
Copy link
Contributor Author

if users will start complaining about worse performance when I release a new version, I'll consider reverting it, but we'll see for now, thanks for merging it! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants