fix: preserve toolbox scroll position when switching between sprites/the stage#10
Merged
gonfunko merged 1 commit intomodern-blocklyfrom May 1, 2024
Merged
fix: preserve toolbox scroll position when switching between sprites/the stage#10gonfunko merged 1 commit intomodern-blocklyfrom
gonfunko merged 1 commit intomodern-blocklyfrom
Conversation
BeksOmega
approved these changes
May 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR preserves the toolbox scroll position when switching between editing targets. This is sort of best effort since the set of available blocks changes when doing this; if the topmost block in the toolbox still exists in the toolbox for the new target, it will appear at the same place at the top of the toolbox; otherwise the relative position within the current category is maintained. This broadly feels like the most correct approach, and seems to generally match what Scratch does. Note that this won't work until RaspberryPiFoundation/blockly-samples#2337 is published and we update to that version of the continuous toolbox.