Filename width fix

[NHOrus]

Some people have unicode filenames. They obviously misalign with naive width calculations.

[NHOrus]

And I am done for today.

[coveralls]

Coverage increased (+0.5%) to 70.69% when pulling ef87533 on NHOrus:namewidth into 2abe4bb on gongo:master.

[coveralls]

Coverage increased (+0.5%) to 70.69% when pulling ef87533 on NHOrus:namewidth into 2abe4bb on gongo:master.

[NHOrus]

As this is a bit more costly than len(string), calling only once per loop and instead using temporary variable.

[gongo]

In my environment:

[NHOrus]

Without filename width patch and with it.
Need to think more about it.

[NHOrus]

And with utf8. RuneCountInString() instead of go-runewidth.

[NHOrus]

Sorry. I don't know.

[gongo]

I will try to check that out too 💪

[gongo]

Hi @NHOrus .
I came up with a good way. I might develop it on another branch. 🙏

[NHOrus]

I think if you succeed it would be great to put in it's own library. Because, well, not a question of width of symbol, but width of a glyph in font.

Also, willing to help with that.

[gongo]

Because, well, not a question of width of symbol, but width of a glyph in font.

Sure.

But, even if it can not be solved in all environments , it may be able to solve to some extent (for example: limited to monospaced fonts) 💪

[emersion]

Maybe this can help? https://godoc.org/golang.org/x/text/width

[gongo]

@NHOrus

I fixed it in GH-7, so close this PR. Thanks !!