all: apply Dan Kortschak API modifications #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kortschak PTAL |
kortschak
approved these changes
Jan 2, 2017
There was a problem hiding this comment.
This LGTM, though we should probably have tests in place before we go much further.
I recall that there were other things that I was intending to do, but I wrote no notes, so I have no idea what they were. The general theme though was taking a rasp to the code and removing the burrs and sharp edges.
Just looking at the code in front of me now, that might continue is the form of e.g. 'GetType() Identifier'->'Type() Identifier' and more idiomatic capitalisation (e.g. 'Datatype'->'DataType')
|
Merge this before the import path changes? |
|
SGTM. are you ok with the commit message? |
|
Yeah, they're fine. Thanks. |
This CL applies API modifications proposed by Dan. This CL renames Location into Identifier and removes the _go_hdf5 prefix from the internal Datatype creation functions.
This was referenced Aug 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LocationIdentifier_go_hdf5prefix (internalDatatype)