Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modules: add go.mod and go.sum and update to modernc.org/cc #56

Merged
merged 1 commit into from
Mar 13, 2019

Conversation

kortschak
Copy link
Member

@kortschak kortschak commented Mar 13, 2019

This moves towards modules support for this repo. For complete support the code generation needs to be made module aware. Until that's done GO111MODULE cannot be set to on. I think the easiest way to do that will be to conditionally determine the path to the source based on whether go list -m gonum.org/v1/gonum is successful. Whether that's done in bash or in the Go code I'm not sure yet.

Please take a look.

@codecov-io
Copy link

codecov-io commented Mar 13, 2019

Codecov Report

Merging #56 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #56   +/-   ##
=======================================
  Coverage   29.64%   29.64%           
=======================================
  Files           2        2           
  Lines        6382     6382           
=======================================
  Hits         1892     1892           
  Misses       4047     4047           
  Partials      443      443

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8cb4219...16afbd7. Read the comment docs.

@kortschak kortschak merged commit f3ee1f4 into master Mar 13, 2019
@kortschak kortschak deleted the modules branch March 13, 2019 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants