Position generated outlines relative to dominant letters #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for teeline-online ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mxdvl
reviewed
Feb 5, 2024
|
|
||
| export const passiveConsonants = ['c', 'f', 'k', 'm', 'n', 'q', 'r', 's', 'v', 'w', 'x', 'y', 'z']; | ||
|
|
||
| export const alphabet = [...vowels, ...dominantConsonants, ...passiveConsonants]; |
There was a problem hiding this comment.
Would be good to add a little test that this arrays create a Set of size 26
| export const createStartingObject = (text: string, lettersObjectArray: OutlineObject[]) => { | ||
| // Identify dominant letter | ||
| const findDominantLetter = (word: string | undefined) => { | ||
| const dominantConsonant = word.split('').find((letter) => dominantConsonants.includes(letter)); |
There was a problem hiding this comment.
What if word is undefined?
Suggested change
| const dominantConsonant = word.split('').find((letter) => dominantConsonants.includes(letter)); | |
| const dominantConsonant = word?.split('').find((letter) => dominantConsonants.includes(letter)); |
frederickobrien
deleted the
position-outlines-relative-to-dominant-letters
branch
This was referenced Feb 9, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses issue #223 by adding a new
createStartingObject()function that's used when generating outline objects. It finds a word's dominant letter and calculates the overall starting point accordingly.Before
After
Yuuuge step forward, this. Generated outlines are going to be so much better. Also opens the door to abstracting a bunch more special outlines (#222).
Potential followup: adjusting the starting point to ensure the outline is always centered.