Move SyllabusLink to learn content template where it belongs
#233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses a longstanding workaround where I was dropping in links between lessons in the svx files rather than at the [slug] level. This was due to a bug/feature (see here for context: sveltejs/kit#552) where the links were getting all messed up. By wrapping the component in a `#key` logic block, ensuring it's recreated any time the slug changes, they don't any more. Best practice? Who knows, but it seems to work
✅ Deploy Preview for teeline-online ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses a longstanding workaround where I was dropping in links between lessons in the learn content svx files rather than at the [slug] level.
The old, rather nasty duplicate approach was due to a bug/feature (see here for context: sveltejs/kit#552) where the links were getting all messed up. By wrapping the component in a
#keylogic block, ensuring it's recreated any time the slug changes, they don't any more. Best practice? Who knows, but it seems to work.Tidier markdown, less code, everything in its right place.