Skip to content

Commit

Permalink
Test historic hook with no callback
Browse files Browse the repository at this point in the history
Ensure that if a result callback (dubbed `proc` for the moment)
provided to `PluginManager.call_historic()` is `None`, no error occurs.

Relates to pytest-dev#110
  • Loading branch information
Tyler Goodlet committed Jan 10, 2018
1 parent 91b2193 commit 2dce4a7
Showing 1 changed file with 27 additions and 6 deletions.
33 changes: 27 additions & 6 deletions testing/test_pluginmanager.py
Original file line number Diff line number Diff line change
Expand Up @@ -183,24 +183,45 @@ def he_method1(self, arg):
assert out == [1, 10, 120, 12]


def test_with_result_memorized(pm):
@pytest.mark.parametrize("result_callback", [True, False])
def test_with_result_memorized(pm, result_callback):
"""Verify that ``_HookCaller._maybe_apply_history()`
correctly applies the ``result_callback`` function, when provided,
to the result from calling each newly registered hook.
"""
out = []
if result_callback:
cb = lambda res: out.append(res)
else:
cb = None

class Hooks(object):
@hookspec(historic=True)
def he_method1(self, arg):
pass

pm.add_hookspecs(Hooks)

class Plugin1(object):
@hookimpl
def he_method1(self, arg):
return arg * 10

pm.register(Plugin1())

he_method1 = pm.hook.he_method1
he_method1.call_historic(lambda res: out.append(res), dict(arg=1))
out = []
he_method1.call_historic(proc=cb, kwargs=dict(arg=1))

class Plugin(object):
class Plugin2(object):
@hookimpl
def he_method1(self, arg):
return arg * 10

pm.register(Plugin())
assert out == [10]
pm.register(Plugin2())
if result_callback:
assert out == [10, 10]
else:
assert out == []


def test_with_callbacks_immediately_executed(pm):
Expand Down

0 comments on commit 2dce4a7

Please sign in to comment.