Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JIRA:GRIF-99 #291

Merged
merged 1 commit into from
Feb 12, 2025
Merged

JIRA:GRIF-99 #291

merged 1 commit into from
Feb 12, 2025

Conversation

alexole01
Copy link
Contributor 

modified:   pom.xml
Upgraded project to JDK17, Spring6

@alexole01 alexole01 force-pushed the aole-gooddata-rest-common branch from 12dcbfa to 432ec2f Compare February 7, 2025 13:47
@alexole01
Copy link
Contributor Author

BREAKING CHANGE: gooddata-rest-common - upgrade to jdk17, spring6, springboot3.
Upgrade gooddata-rest-common to jdk17, spring6.
JIRA: GRIF-99

@alexole01 alexole01 self-assigned this Feb 7, 2025
@alexole01
Copy link
Contributor Author

please review

@jiri-staroba
Copy link

LGTM

@jiri-staroba jiri-staroba requested a review from xvalovic February 7, 2025 15:07
petr-klemsinsky
petr-klemsinsky previously requested changes Feb 7, 2025
View reviewed changes
Copy link

@petr-klemsinsky petr-klemsinsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update commit message to conform Conventional commits and https://gooddata.atlassian.net/wiki/spaces/pap/pages/1720778756/Commit+Message+Guideline.

@alexole01 alexole01 force-pushed the aole-gooddata-rest-common branch 2 times, most recently from abef5c4 to 42f66d2 Compare February 11, 2025 11:28
@alexole01 alexole01 force-pushed the aole-gooddata-rest-common branch from 02326f9 to f9b9815 Compare February 12, 2025 10:03
@alexole01 alexole01 enabled auto-merge February 12, 2025 10:06
@alexole01 alexole01 removed the request for review from jiri-staroba February 12, 2025 10:07
@alexole01 alexole01 merged commit 280a332 into master Feb 12, 2025
1 check passed
@alexole01 alexole01 deleted the aole-gooddata-rest-common branch February 12, 2025 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xvalovic xvalovic xvalovic approved these changes

@petr-klemsinsky petr-klemsinsky petr-klemsinsky left review comments

Assignees

@alexole01 alexole01

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alexole01 @jiri-staroba @petr-klemsinsky @xvalovic