Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Librato 'counters' in addition to 'gauges' #37

Closed
wants to merge 3 commits into from

Conversation

mmoskal
Copy link

@mmoskal mmoskal commented May 2, 2015

Currently the module reports increment() as Librato gauges, but librato also has a counter type (http://dev.librato.com/v1/post/metrics). This patch adds option counters:true to report increment() calls as counters.

@mmoskal
Copy link
Author

mmoskal commented May 3, 2015

After some experimenting, this is not as useful as I thought - librato expects the client to keep track of the counter, not only post increments.

@mmoskal mmoskal closed this May 3, 2015
@garnold
Copy link

garnold commented May 3, 2015

@mmoskal That is actually the correct behavior. Other statistics collection frameworks, such as Collectd, work the same way. See discussion of #36 and #27. Would love it if you'd consider reopening this pull request 👍

@mmoskal mmoskal reopened this May 3, 2015
@mmoskal
Copy link
Author

mmoskal commented May 3, 2015

Re-opened, and updated to make it work in non-distributed setting.

@garnold
Copy link

garnold commented May 3, 2015

Thanks @mmoskal !

@bobzoller
Copy link
Contributor

@mmoskal @garnold I think #27 / #40 (which just landed) eliminates the need for this. It might still be nice to offer users the ability to choose gauges or counters for increment, but it seems like counters should be the default (and now they are).

I'm going to close this until we hear folks need the choice.

@bobzoller bobzoller closed this May 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants