Fix package installation by switching to hatchling build backend#2
Open
mjclarke94 wants to merge 2 commits intogoodfire-ai:mainfrom
Open
Fix package installation by switching to hatchling build backend#2mjclarke94 wants to merge 2 commits intogoodfire-ai:mainfrom
mjclarke94 wants to merge 2 commits intogoodfire-ai:mainfrom
Conversation
…figuration Previously, installing scribe as a package (e.g., via 'uv add git+...') would fail with 'ModuleNotFoundError: No module named scribe.cli' because subpackages weren't included in the distribution. Editable installs worked fine. Switched to hatchling build backend which automatically discovers and includes all subpackages in the built package.
|
Would be great to have this merged! Or some other fix that allows scribe to be installed as a dependency straight from git, rather than local files. Several fixes are possible. |
|
I'd like this too. I note that if you did want to stick to setuputils, a fix would be |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Installing scribe as a package (e.g.,
uv add git+https://github.com/goodfire-ai/scribe.git) would fail with:This occurred because subpackages (
scribe.cli,scribe.notebook,scribe.providers) weren't being included in the built distribution. Editable installs (uv pip install -e .) worked fine since they reference the source directory directly.Solution
[build-system]configuration with hatchling as the build backenduv addas the default installation methodTesting
Verified that
uv add git+<fork-url>@fix/package-installationsuccessfully installs scribe with all subpackages accessible, and thescribeCLI command works as expected.