Mask the full weight for shared_across_batch#323
Draft
danbraunai-goodfire wants to merge 1 commit intomainfrom
Draft
Mask the full weight for shared_across_batch#323danbraunai-goodfire wants to merge 1 commit intomainfrom
danbraunai-goodfire wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
messy test for a speedup which takes advantage of the fact that PGD shared_across_batch doesn't have mask values for the batch and sequence position. This let's us mask V directly instead of doing x @ V and then masking the acts. Results of this on ss_llama_simple_mlp (4L) are below:
So this is a reasonable speedup. The code is quite gross, but there are probably ways to improve it so that it doesn't add much bloat to main.
Related Issue
Motivation and Context
How Has This Been Tested?
Does this PR introduce a breaking change?